Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow git.latest to remove local tags which have been removed remotely #49305

Merged
merged 5 commits into from Aug 24, 2018

Conversation

Projects
None yet
4 participants
@terminalmage
Copy link
Contributor

commented Aug 24, 2018

Before, this state would simply perform a symmetric difference between the local and remote tags. This would result in tags which were removed remotely being incorrectly identified as newly-fetched tags in the changes dict, since they still existed locally.

This PR modifies the state so that tags present locally (but not remotely) will be removed. This functionality is gated behind a new argument to the state called sync_tags, which defaults to True (i.e. enabled).

Fixes #48299.

@dwoz

dwoz approved these changes Aug 24, 2018

terminalmage added some commits Aug 23, 2018

@terminalmage terminalmage force-pushed the terminalmage:issue48299 branch from e8c0c1d to 4a093d9 Aug 24, 2018

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Aug 24, 2018

Should be fixed now.

@gtmanfred gtmanfred merged commit b65890c into saltstack:2018.3 Aug 24, 2018

7 of 8 checks passed

jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.