New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-port #49303 to 2018.3.3 #49311

Merged
merged 1 commit into from Aug 24, 2018

Conversation

Projects
None yet
3 participants
@rallytime
Contributor

rallytime commented Aug 24, 2018

Back-port #49303 to 2018.3.3

use os._exit instead of sys.exit when daemonizing
According to the docs [here](https://docs.python.org/3/library/os.html#os._exit)

> `os._exit` should should normally only be used in the child process after a fork().

This will exit the process with status n, without calling cleanup
handlers, flushing stdio buffers, etc.

Fixes saltstack/salt-jenkins#1075

@rallytime rallytime merged commit 7a89a4c into saltstack:2018.3.3 Aug 24, 2018

6 of 8 checks passed

jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@rallytime rallytime deleted the rallytime:bp-49303 branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment