Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci scripts for windows PR builds #49324

Merged
merged 4 commits into from Aug 28, 2018

Conversation

Projects
None yet
5 participants
@dwoz
Copy link
Contributor

commented Aug 24, 2018

What does this PR do?

Adding Jenkins ci scripts for windows PR builds. These won't actually run until Jenkins is configured to use them.

Tests written?

No

Commits signed with GPG?

Yes

@dwoz dwoz requested review from pizzapanther, cachedout and dubb-b Aug 24, 2018

@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2018

I used replay to setup the py2/3-windows-2016 tests

@gtmanfred gtmanfred self-requested a review Aug 25, 2018

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2018

At least one of the failures in these windows PR builds would have been caught by actual PR builds (see #49337). The others look flakey. I'll be making a pass on marking flakey tests as such soon.

@dwoz dwoz changed the title [WIP] Add ci scripts for windows PR builds Add ci scripts for windows PR builds Aug 27, 2018

@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2018

@KaiSforza @dubb-b we need to add more workers before we merge this, because we are now going to run 6 tests per pr.

Mike Place
@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Aug 27, 2018

@KaiSforza Please let us know as soon as those workers are ready to go.

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2018

This PR fixes the boto test errors:

#49353

@dwoz dwoz requested review from KaiSforza and removed request for pizzapanther Aug 27, 2018

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Aug 28, 2018

Bump @KaiSforza. Are the workers ready?

@KaiSforza

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2018

We now have 180 executors (9 nodes, 20 executors each) ready for kitchen. We should be good @cachedout

@gtmanfred gtmanfred merged commit b22a43d into saltstack:2017.7 Aug 28, 2018

4 of 8 checks passed

jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
@KaiSforza

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2018

If needed we can bump it back up to 25 or 30 and get to 225 or 270.

@dwoz dwoz deleted the dwoz:windows_pr_builds branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.