Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix issues with win_service #49327
What does this PR do?
What issues does this PR fix or reference?
Commits signed with GPG?
The other alternative is to check for begins with " then leave it alone, otherwise wrap " around it after running escape_argument or escape_for_cmd_exe
Since this is the service module, I can't think of an instance where the path to an exe would start or end with a single quote. It would always end in
@twangboy I was wrong about escape_for_cmd_exe() as it should only be used for cmd.exe
Two fixes available
The above will support
And not support
And if this code is introduced here to help, then it needs to be introduced in other places for consistency, is that doable or will it require to much
Example of inconsistency is the
Please go with option A.
@twangboy It looks like there is a related windows test failing here:
Yay for catching that now!