Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve management of interfaces in debian-based distributions #49355

Merged
merged 14 commits into from Aug 30, 2018

Conversation

Projects
None yet
5 participants
@MTecknology
Copy link
Contributor

commented Aug 28, 2018

What does this PR do?

This commit fixes a lot of issues with managing network interfaces on Debian-based distributions.

  • Cleaned up documentation/examples in states.network:
    • Updated debian-based distro comment
    • Fixed example of configuring a loopback device
    • Cleaned up copy/paste mistakes
    • Added more examples
    • Verified examples work on Debian 9
  • Added support for -ipaddrs and -ipv6ipaddrs to modules.debian_ip().
  • Added support for loopback devices to modules.debian_ip(). (Fixes: #38672)
  • Added a bunch of unit tests for modules.debian_ip.build_interface().
  • Added support for dns_{nameservers,search} being a list or string.
  • Added support for multiple addresses per interface

What issues does this PR fix or reference?

Tests written?

Yes

Commits signed with GPG?

Yes

MTecknology added some commits Aug 28, 2018

Cleaned up documentation/examples in states.network:
- Updated debian-based distro comment
- Fixed example of configuring a loopback device
- Cleaned up copy/paste mistakes
- Added more examples
- Verified examples work on Debian 9

MTecknology added some commits Aug 28, 2018

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Aug 28, 2018

@MTecknology Thanks for this. I'm afraid there is a failing test, though. Could you please take a look?

MTecknology added some commits Aug 28, 2018

@rallytime
Copy link
Contributor

left a comment

Thank you for writing that test!

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

@MTecknology That test is failing on CentOS 7. Can you take another look?

https://jenkinsci.saltstack.com/job/pr-kitchen-centos7-py3/job/PR-49355/10/

MTecknology added some commits Aug 29, 2018

@rallytime rallytime merged commit e576b87 into saltstack:develop Aug 30, 2018

7 of 9 checks passed

codeclimate 3 issues to fix
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@MTecknology MTecknology deleted the MTecknology:debian-networking branch Aug 30, 2018

@Ch3LL

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2018

@garethgreenaway what branch do you need this backported to?

@garethgreenaway

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

@Ch3LL should go back to 2018.3

@Ch3LL Ch3LL referenced this pull request Dec 10, 2018

Merged

Back-port #49355 to 2018.3 #50804

cachedout pushed a commit that referenced this pull request Dec 10, 2018

Mike Place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.