New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-port #49322 to 2018.3.3 #49368

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
2 participants
@rallytime
Contributor

rallytime commented Aug 28, 2018

Back-port #49322 to 2018.3.3

Encode shell commands explicitly.
On Windows subprocess.Popen will try to implicity encode shell commands
using the default system encoding. This will raise an exception if
passed utf-8.

@rallytime rallytime merged commit af80e64 into saltstack:2018.3.3 Aug 28, 2018

5 of 8 checks passed

jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details

@rallytime rallytime deleted the rallytime:bp-49322 branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment