Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix winrepo.update_git_repos for masterless minion #49387

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@twangboy
Copy link
Contributor

commented Aug 28, 2018

What does this PR do?

Fixes an issue where the minion would stacktrace when running the following:

salt-call --local -l debug winrepo.update_git_repos

Stacktrace:

[ERROR   ] Failed to update winrepo_remotes: name 'GLOBAL_ONLY' is not defined
Traceback (most recent call last):
  File "c:\dev\salt\salt\runners\winrepo.py", line 225, in update_git_repos
    GLOBAL_ONLY)
NameError: name 'GLOBAL_ONLY' is not defined

What issues does this PR fix or reference?

None. Found while preparing presentation

Tests written?

No

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Aug 28, 2018

@dwoz

dwoz approved these changes Aug 29, 2018

@rallytime rallytime merged commit 11d87e4 into saltstack:2017.7 Aug 29, 2018

3 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details

@twangboy twangboy deleted the twangboy:fix_win_repo branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.