Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make file envs compatible with fileclient formats #49389

Merged
merged 5 commits into from Aug 29, 2018

Conversation

Projects
None yet
5 participants
@gtmanfred
Copy link
Contributor

commented Aug 29, 2018

What issues does this PR fix or reference?

Bug brought up in #dev in corporate slack

Tests written?

Yes

Commits signed with GPG?

Yes

gtmanfred added some commits Aug 29, 2018

@gtmanfred gtmanfred requested a review from saltstack/team-core as a code owner Aug 29, 2018

@gtmanfred gtmanfred changed the title make file envs compatible with transport format make file envs compatible with fileclient formats Aug 29, 2018

@dwoz

dwoz approved these changes Aug 29, 2018

@dwoz
Copy link
Contributor

left a comment

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

@gtmanfred gtmanfred force-pushed the gtmanfred:2017.7 branch from c5d28b5 to 251f321 Aug 29, 2018

@terminalmage
Copy link
Contributor

left a comment

I tried to submit a review RE: passing the payload directly to self.envs() and @gtmanfred went and fixed it in the time it took me to type my review. 👍

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Aug 29, 2018

@gtmanfred We have a failed test here: integration.modules.test_cp.CPModuleTest.test_envs

@dwoz

dwoz approved these changes Aug 29, 2018

@gtmanfred

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2018

The test /should/ be fixed, may need to sort it.

@gtmanfred gtmanfred merged commit 7099164 into saltstack:2017.7 Aug 29, 2018

3 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details

terminalmage added a commit to terminalmage/salt that referenced this pull request Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.