Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue#49150 hosts.rm_host changes /etc/hosts with odd characters #49394

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@sunyq
Copy link

commented Aug 29, 2018

What does this PR do?

fix the issue that hosts.rm_host changes /etc/hosts with odd characters

What issues does this PR fix or reference?

fix the bug mentioned in issue 49150
Be sure to transfer all 'content' to bytes before writing into file.

Tests written?

No

Commits signed with GPG?

No

@dwoz dwoz requested a review from rallytime Aug 29, 2018

@dwoz

dwoz approved these changes Aug 29, 2018

@rallytime rallytime merged commit 502e91c into saltstack:2018.3 Aug 29, 2018

7 of 8 checks passed

jenkins/pr/py2-centos-7 running py2-centos-7...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.