Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow our custom yaml dumper to NamespacedDictWrapper objects #49408

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
3 participants
@terminalmage
Copy link
Contributor

commented Aug 29, 2018

This special dict class did not have a representer assigned to it, so PyYAML would raise an exception when attempting to dump it.

This also removes the class name overriding, as its implementation was ill-conceived and will be deprecated in a later branch (it's only used in this one place so deprecating should be of no-to-minimal impact).

Allow our custom yaml dumper to NamespacedDictWrapper objects
This special dict class did not have a representer assigned to it, so
PyYAML would raise an exception when attempting to dump it.

This also removes the name overriding, as its implementation was
ill-conceived and will be deprecated in a later branch (it's only used
in this one place so deprecating should be of no-to-minimal impact).

@terminalmage terminalmage requested a review from saltstack/team-core as a code owner Aug 29, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Aug 29, 2018

@rallytime
Copy link
Contributor

left a comment

🎉

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

@terminalmage This fixes #49269, yeah?

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2018

@rallytime that is correct

@cachedout cachedout merged commit 24faa5e into saltstack:2017.7 Aug 29, 2018

2 of 9 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details

@terminalmage terminalmage deleted the terminalmage:issue49269 branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.