Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up exception handling on py3 #49434

Merged
merged 2 commits into from Aug 30, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Copy link
Contributor

commented Aug 29, 2018

What does this PR do?

Exceptions are not iterable under python 3, expand the Exception's args parameter instead.

Tests written?

No - Clean up errors in existing tests

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Aug 29, 2018

@dwoz dwoz requested a review from twangboy Aug 29, 2018

@rallytime rallytime merged commit 03d9750 into saltstack:2017.7 Aug 30, 2018

4 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details

@dwoz dwoz deleted the dwoz:cleanup_exception_handling branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.