Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove string conversion on frame object in sigusr1 handler #49471

Merged
merged 1 commit into from Sep 2, 2018

Conversation

Projects
None yet
3 participants
@Ch3LL
Copy link
Contributor

commented Aug 31, 2018

What does this PR do?

remove to_str conversion on frame object.

What issues does this PR fix or reference?

#49463

Previous Behavior

stack trace when sending sigusr1 signal to master

TypeError: expected str, bytearray, or unicode

New Behavior

correctly prints out the frame object information to the debug file.

Tests written?

No

Commits signed with GPG?

Yes

@rallytime rallytime requested a review from terminalmage Aug 31, 2018

@cachedout cachedout merged commit 43ead5d into saltstack:2018.3 Sep 2, 2018

5 of 8 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.