Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around git-python resource leaks #49474

Merged
merged 2 commits into from Sep 2, 2018

Conversation

Projects
None yet
2 participants
@dwoz
Copy link
Contributor

commented Aug 31, 2018

Git python keeps file handles open on repositories. This does not see to
effect tests outside of python3 on widows. For now, use a new temporary
for each test on python3 windows.

Tests written?

No - Fixing failing unit tests

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from gtmanfred Aug 31, 2018

Work around git-python resource leaks
Git python keeps file handles open on repositories. This does not see to
effect tests outside of python3 on widows. For now, use a new temporary
for each test on python3 windows.

@dwoz dwoz force-pushed the dwoz:gitfs_unit branch from cffbec7 to e697ddc Aug 31, 2018

@dwoz dwoz merged commit 93df5c4 into saltstack:2018.3 Sep 2, 2018

4 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details

@dwoz dwoz deleted the dwoz:gitfs_unit branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.