Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix X509 remote signing on python3 #49508

Merged
merged 4 commits into from Sep 6, 2018

Conversation

Projects
None yet
8 participants
@bergmannf
Copy link
Contributor

commented Sep 5, 2018

What does this PR do?

It fixes the x509 module to work, when using the sign_remote_certificate functionality.

What issues does this PR fix or reference?

Another part for fixing https://bugzilla.suse.com/show_bug.cgi?id=1106382.

Previous Behavior

Remote signing would not work and fail with an error salt.exceptions.SaltInvocationError: PEM does not contain a single entry of type CERTIFICATE:

New Behavior

Remote signing works again.

Tests written?

No, however a repository with a reproducer can be found here.

Please review Salt's Contributing Guide for best practices.

bergmannf added some commits Sep 4, 2018

Convert to string before sending via 'publish'.
Otherwise the publish call with receive a "b''" string, which can not be used
in the functions.
Do not silently ignore errors.
At least log the occurring errors to debug and trace.

@bergmannf bergmannf changed the title X509 remote signing Fix X509 remote signing on python3 Sep 5, 2018

@isbm

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2018

@isbm

isbm approved these changes Sep 5, 2018

@dwoz

dwoz approved these changes Sep 6, 2018

@rallytime rallytime merged commit 7bde9a7 into saltstack:develop Sep 6, 2018

6 of 9 checks passed

codeclimate 2 issues to fix
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details

@Poil Poil referenced this pull request Nov 29, 2018

Closed

Fix python3 x509 #50676

@dawidmalina

This comment has been minimized.

Copy link
Contributor

commented Dec 28, 2018

Is this fix going to be backported to 2018.3?

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

@garethgreenaway

This comment has been minimized.

Copy link
Member

commented Jan 11, 2019

@rallytime thanks! Labeled for a back port. 😁

@isbm

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

It is already. If we forgot to submit, you can cherry pick that from us: openSUSE/salt@053d97a

@Ch3LL it is actually a good idea to just take it from SUSE, so we will get rid of corresponding patches in our 2019.2 packages. 😉

@isbm

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

In the meanwhile, we've just packaged RC1 and all these x509 fixes are there too. You can try it in SUSE OBS.

@isbm

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

@Ch3LL Ch3LL referenced this pull request Jan 11, 2019

Merged

Back-port #49508 to 2018.3 #51150

@Ch3LL

This comment has been minimized.

Copy link
Contributor

commented Jan 11, 2019

I backported this to 2018.3 here: #51150

dwoz added a commit that referenced this pull request Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.