New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Disabling State boto tests for Python 3.7+ #49548

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@garethgreenaway
Member

garethgreenaway commented Sep 6, 2018

What does this PR do?

Disable various boto tests when run under python 3.7 which was causing the test suite to hang on unit tests. This PR is disabling the tests in the test_boto_vpc state tests.

What issues does this PR fix or reference?

saltstack/salt-jenkins#1075

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Disable various boto tests when run under python 3.7 because of //git…
…hub.com/spulec/moto/issues/1706. which was causing the test suite to hang on unit tests.  This PR is disabling the tests in the test_boto_vpc state tests.

@garethgreenaway garethgreenaway requested review from rallytime and Ch3LL Sep 6, 2018

@garethgreenaway garethgreenaway merged commit 3298e70 into saltstack:2018.3 Sep 6, 2018

5 of 10 checks passed

jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details

garethgreenaway added a commit that referenced this pull request Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment