Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple unittest fixes for 2018.3 Python 3 Windows #49577

Merged
merged 1 commit into from Sep 8, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Copy link
Contributor

commented Sep 7, 2018

What does this PR do?

Fix the following unit tests:

unit.utils.test_json.JSONTestCase.test_dump_load
unit.utils.test_files.FilesTestCase.test_safe_walk_symlink_recursion
unit.utils.test_jinja.TestGetTemplate.test_non_ascii
unit.utils.test_jinja.TestGetTemplate.test_non_ascii_encoding

What issues does this PR fix or reference?

Tests written?

No - Fixing failing tests

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from twangboy Sep 7, 2018

@dwoz dwoz merged commit 4669a9a into saltstack:2018.3 Sep 8, 2018

6 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit is being built
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.