Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setup.py clean --all #49578

Merged
merged 2 commits into from Sep 10, 2018

Conversation

Projects
None yet
4 participants
@twangboy
Copy link
Contributor

commented Sep 7, 2018

What does this PR do?

Changes the way the salt repo is cleaned during the build process. Uses setup.py clean --all for the build directory. Checks for the existence of the dist directory before attempting to delete it.

What issues does this PR fix or reference?

#49566

Tests written?

NA

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from saltstack/team-windows Sep 7, 2018

@dwoz

dwoz approved these changes Sep 7, 2018

Mike Place

@rallytime rallytime merged commit 63b6643 into saltstack:2017.7 Sep 10, 2018

6 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@twangboy twangboy deleted the twangboy:fix_49566 branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.