Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to whitelist for Windows #49593

Merged
merged 14 commits into from Sep 17, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Copy link
Contributor

commented Sep 10, 2018

What does this PR do?

Add more test file to whitelist.txt for Windows builds.

Tests written?

No

Commits signed with GPG?

Yes

dwoz added some commits Sep 10, 2018

self.assertEqual(
'ERROR executing \'file.remove\': File path must be absolute: tty', ret
)
if salt.utils.platform.is_windows():

This comment has been minimized.

Copy link
@cachedout

cachedout Sep 10, 2018

Collaborator

Should we just normalize this error message in the module itself instead?

This comment has been minimized.

Copy link
@dwoz

dwoz Sep 10, 2018

Author Contributor

Yes, Assuming we require an absolute path for both platforms. I think we do but I'll verify that and then change the message if needed.

dwoz added some commits Sep 11, 2018

Fix map file loading on windows
Prevent exceptions on windows from lines trying to be decoded/encoded to
ascii
Fix multiple issues in x509 module and state
Adding a regression test for #49008 and patching the x509 module and
state to make the test pass.

@dwoz dwoz force-pushed the dwoz:add_whitelist branch from 02ceb31 to be5fccf Sep 11, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2018

@dwoz dwoz force-pushed the dwoz:add_whitelist branch 2 times, most recently from c88dc69 to 7439496 Sep 15, 2018

@dwoz dwoz force-pushed the dwoz:add_whitelist branch from 7439496 to 2340a58 Sep 15, 2018

@rallytime rallytime merged commit e636dac into saltstack:2018.3 Sep 17, 2018

6 of 9 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@dwoz dwoz deleted the dwoz:add_whitelist branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.