New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixing integration.states.test_file.FileTest.test_directory_max_depth #49632

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
2 participants
@garethgreenaway
Member

garethgreenaway commented Sep 12, 2018

What does this PR do?

Fixing failing test under python 3.7 causaed by changes to how os.makedirs sets initial permissions.

What issues does this PR fix or reference?

saltstack/salt-jenkins#1075

Previous Behavior

integration.states.test_file.FileTest.test_directory_max_depth failed

New Behavior

integration.states.test_file.FileTest.test_directory_max_depth succeeds.

Tests written?

Existing test updated.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@garethgreenaway garethgreenaway requested review from Ch3LL and rallytime Sep 12, 2018

@rallytime rallytime merged commit 93d43fa into saltstack:2018.3 Sep 13, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

rallytime added a commit that referenced this pull request Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment