Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to whitelist #49679

Merged
merged 14 commits into from Sep 22, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Copy link
Contributor

commented Sep 17, 2018

What does this PR do?

Add more tests to whitelist and make sure they pass.

Tests written?

No

Commits signed with GPG?

Yes

@dwoz dwoz requested a review from rallytime Sep 17, 2018

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2018

Looks like there are some test failures I need to look at.

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2018

@rallytime I've increased the ModuleTest.run_function timeout to help with this issue:

saltstack/salt-jenkins#1116

@dwoz dwoz force-pushed the dwoz:whitelist branch 2 times, most recently from 5a660fb to 34b52b4 Sep 18, 2018

dwoz added some commits Sep 17, 2018

Increase ModuleTest.run_function timeout
Reduce flakyness with greater timeout

@dwoz dwoz force-pushed the dwoz:whitelist branch 3 times, most recently from a2d5a40 to e1e9111 Sep 19, 2018

@dwoz dwoz force-pushed the dwoz:whitelist branch from e1e9111 to 1f60753 Sep 20, 2018

dwoz added some commits Sep 20, 2018

@dwoz dwoz merged commit ec2386e into saltstack:2018.3 Sep 22, 2018

5 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.