Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Detect when system needs reboot after domain join #49684
What does this PR do?
Properly detects if the system requires reboot after Joining a domain.
What issues does this PR fix or reference?
Commits signed with GPG?
@twangboy The following windows test failures look related to me:
Can you fix those?
@rallytime, This is none of my business I suppose. I don't know how the testing works. Certainly, the get_computer_name function works for me (on Windows 10). (I haven't looked at the other two functions). How can one know the particulars of the test system in order to duplicate the environment? Can it be ascertained that the test system has no permissions issues and so forth?
The test issues may or may not be related to each other but I don't see how they're related to the bugs @twangboy just fixed