Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect when system needs reboot after domain join (2017.7) #49703

Merged
merged 2 commits into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@twangboy
Copy link
Contributor

commented Sep 18, 2018

What does this PR do?

DO NOT MERGE FORWARD

Registry functions used by this module have been moved into salt.utils. This is handled differently in 2018.3+.

Fix issues with detecting when a system needs a reboot. Fixes the following functions:

  • get_pending_update
  • get_pending_domain_join
  • get_pending_component_servicing

What issues does this PR fix or reference?

#49675

Tests written?

No

Commits signed with GPG?

Yes

Fix reboot needed detection
Fix the following:
- get_pending_update
- get_pending_domain_join
- get_pending_component_servicing

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Sep 18, 2018

@twangboy twangboy added the 2017.7.9 label Sep 18, 2018

@dwoz

dwoz approved these changes Sep 19, 2018

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Sep 19, 2018

Interesting. This failed two Windows tests but in different ways. I'm going to re-run the test suite.

Mike Place

@cachedout cachedout merged commit 5ef2def into saltstack:2017.7 Sep 20, 2018

9 of 10 checks passed

jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@twangboy twangboy deleted the twangboy:fix_49675_2017.7 branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.