Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2017.7] Removing os.path.join mocking from tests. #49706

Conversation

Projects
None yet
3 participants
@garethgreenaway
Copy link
Member

commented Sep 18, 2018

What does this PR do?

Removing mocking of os.path.join from two tests, one of which was failing when used with coverage argument. No reason we should be mocking os.path.join.

What issues does this PR fix or reference?

saltstack/salt-jenkins#1120

Previous Behavior

Test was failing.

New Behavior

Test now succeeds.

Tests written?

Yes. Updated existing tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

Removing mocking of os.path.join from two tests, one of which was fai…
…ling when used with coverage argument. No reason we should be mocking os.path.join.
@rallytime
Copy link
Contributor

left a comment

👍

@garethgreenaway garethgreenaway merged commit 6bd85b5 into saltstack:2017.7 Sep 19, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.