Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Seperate prlctl and prlsrvctl checks into each requiring function #49720
What does this PR do?
Split and move the availability checks for prlctl or prlsrvctl to each function requiring it.
What issues does this PR fix or reference?
Loading the Parallels module will fail if the prlsrvctl binary can't be found, whereas prlsrvctl is only required for one function: prlsrvclt().
Only prlsrvctl() requires the prlsrvctl binary.
Commits signed with GPG?
rallytime left a comment
This looks fine to me, but I think this would be a good opportunity to document the requirements more clearly as dependencies.
I see at the top of the file there are statements about what is or is not built with the various prlctl/prlsrvctl commands, but we don't say that either library is a dependency.
Can you add that to the docs?
@cstarke Welcome! I have a small request above.
It also looks like this change is causing some tests to fail. Can you take a look?
@cstarke Sorry, I was not being clear.
I just mean that we should document somewhere that some functions require one library or the other.
That way people don't have to run the function and hit the
Or something along those lines.