Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Populate changes dictionary on system.join_domain #49739
What does this PR do?
Fixes issue with the
What issues does this PR fix or reference?
Commits signed with GPG?
Thanks @twangboy. I have to point out that I think that the restart switch for this function should probably be deprecated, since we now have the system.reboot state (which is supposed to know about the pending domain join). Also the restart switch comes with no options, which means that it always has a five minute timeout. A sysadmin doing a domain join typically won't want a five minute timeout at that time since joining is usually a deployment step. Even if the reboot flag isn't deprecated it should result in an immediate reboot.
@twangboy Can you look into this test failure?