Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for clonenum parameter #49752

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
3 participants
@jodok
Copy link
Contributor

commented Sep 23, 2018

What does this PR do?

It adds support for the clonenum_start parameter for RHEL7 based systems as documented in https://docs.saltstack.com/en/latest/ref/states/all/salt.states.network.html.

What issues does this PR fix or reference?

#49751

Tests written?

No

Commits signed with GPG?

Yes

@rallytime rallytime merged commit 0cd71cb into saltstack:develop Sep 24, 2018

5 of 11 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
@rallytime

This comment has been minimized.

Copy link
Contributor

commented Sep 24, 2018

Thanks @jodok and congrats on your first Salt PR!

@jodok jodok deleted the jodok:jb/clonenum branch Sep 24, 2018

@jodok

This comment has been minimized.

Copy link
Contributor Author

commented Oct 27, 2018

is it by intend that this change hasn't made it to 2018.3.3?

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 29, 2018

Hi @jodok - This change was submitted ot the develop branch, which is why it is not included in 2018.3.3. I have back-ported this to 2018.3 for inclusion in the 2018.3.4 release.

In the future, please submit bug fixes to the branch that the fix applies to and then they will get merged forward to newer releases as well. You can learn more about that process here or I am happy to answer any questions!

cachedout pushed a commit that referenced this pull request Nov 1, 2018

Mike Place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.