Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[2018.3] Adding retry_dns_count to minion #49764
What does this PR do?
Updating the resolve_dns function in minion.py to include a new minion configuration option which will control how many attempts will be made when the master hostname is unable to be resolved before giving up.
What issues does this PR fix or reference?
When a including a master hostname that doesn't resolve, particular in a multi-master setup, the resolve_dns function in the minion will continue indefinitely and never move onto other minions.
This change updates that function to look for a new minion configuration option,
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
isbm left a comment
I would rather set this default to a long enough, reasonable amount of times and bail out. Say, put 50 if you want. If then anyone wants to keep it until forever, should do it explicitly.