Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing an issue where sentry logger would fail to get tags from grain… #49790

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@weswhet
Copy link
Contributor

commented Sep 26, 2018

What does this PR do?

Fixes #49766

What issues does this PR fix or reference?

#49766

Previous Behavior

Would fail when specifying any tags for sentry.

New Behavior

Sends grains as tags, as expected.

Tests written?

No

Commits signed with GPG?

Yes

fixing an issue where sentry logger would fail to get tags from grain…
…s and some other lint fixes for this file
@weswhet

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2018

Sorry for the mix up on PRs, git is hard 😞

@rallytime
Copy link
Contributor

left a comment

Not a problem. :)

Thanks for moving this to the 2018.3 branch!

@rallytime rallytime merged commit d191b08 into saltstack:2018.3 Sep 28, 2018

7 of 10 checks passed

jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.