Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saltnado: teach runner about full_return #49798

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
4 participants
@mattp-
Copy link
Contributor

commented Sep 26, 2018

What does this PR do?

runnerclient sync interface allows for a full_return kwarg to exist
outside of the low to flag when the full event body is wanted with
metadata instead of just the inner result. Since saltnado only uses the
async interface we teach it about the sync wrapper about this kwarg.

What issues does this PR fix or reference?

not sure.

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Tests written?

No

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

saltnado: teach runner about full_return
runnerclient sync interface allows for a full_return kwarg to exist
outside of the low to flag when the full event body is wanted with
metadata instead of just the inner result. Since saltnado only uses the
async interface we teach it about the sync wrapper about this kwarg.

@salt-jenkins salt-jenkins requested a review from Sep 26, 2018

@rallytime rallytime requested review from DmitryKuzmenko and gtmanfred Sep 26, 2018

@rallytime
Copy link
Contributor

left a comment

LGTM

@cachedout cachedout merged commit b66d468 into saltstack:develop Oct 1, 2018

8 of 11 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
codeclimate All good!
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

rallytime added a commit that referenced this pull request Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.