Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: zypper ZYPPER_EXIT_NO_REPOS exit code #49806

Merged
merged 2 commits into from Sep 28, 2018

Conversation

Projects
None yet
4 participants
@isbm
Copy link
Contributor

commented Sep 27, 2018

What does this PR do?

pkg.installed reports failed if the following conditions are met:

  1. No repos configured
  2. Package already installed anyway

What issues does this PR fix or reference?

pkg.installed does not report failed if the following conditions above are met.

Caveats

Zypper (all versions) still contains a bug (which is already fixed as of today) — https://bugzilla.suse.com/show_bug.cgi?id=1109893 — where new package installation fails with the same exit code. That said, pkg.installed will work, but pkg.install from execution command will not fail, if you did not upgrade zypper.

Tests written?

No

Should just pass existing.

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Sep 27, 2018

@meaksh

meaksh approved these changes Sep 27, 2018

@brejoc

brejoc approved these changes Sep 28, 2018

@rallytime rallytime merged commit 52b0472 into saltstack:2018.3 Sep 28, 2018

7 of 10 checks passed

jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.