Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add additional asserts to help investigate test_win_pkg failure #49809
Just looking at the windows test and there are hundreds of these lines
@damon-atkins We added the unix2dos conversion a month or two ago. This was done because, by default, git will perform newline translations and git clones on Windows will have CRLF line endings. By running unix2dos the tests run with the same line endings as if someone runs the tests from a git clone on windows.
Due to the fact that git can be configured to perform newline translations (or not), using unix2dos is not ideal. Since you could perform a git clone without newline translations and then see some failures in the test suite because of that.
In addition, as you have pointed out, using unix2dos does not cover the case where you have a linux master with windows minion. It means the test suite primarily testing a Windows master with a Windows minion.
I think long term we want to enumerate all possible line ending cases and test all of them. We're just not there yet. A couple other things to think about is the fact that YAML performs line ending translation so that values parsed by YAML always have LF line endings even if the source file has CRLF line endings. JSON on the other hand should always have LF line endings source files.
Hopefully this explains why we are using unix2dos for now and the direction we are heading.