Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing mis-spelling of lattrs in file.py, referncing #49204 #49827

Merged
merged 1 commit into from Sep 30, 2018

Conversation

Projects
None yet
4 participants
@dgmorrisjr
Copy link

commented Sep 28, 2018

per request from @gtmanfred, creating a pull request

What does this PR do?

Correct the mis-spelling of lattrs in the except block, line 4514

What issues does this PR fix or reference?

when running a file action that recurses (e.g. recurse owner, group, mode, etc), the state would fail. Found this issue in 2018.1 and discovered that it was being fixed in latest develop branch.

lattrs is mis-spelled in this line. if the except condition fires, then the following if lattrs is not None: line will throw an local variable 'lattrs' referenced before assignment error.

Previous Behavior

local variable 'lattrs' referenced before assignment error

Tests written?

No

Commits signed with GPG?

No

@gtmanfred
Copy link
Contributor

left a comment

Awesome, thanks for this @dgmorrisjr

@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2018

great catch!

@dgmorrisjr

This comment has been minimized.

Copy link
Author

commented Sep 28, 2018

happy to help !

@cachedout cachedout merged commit 8a8a7fe into saltstack:develop Sep 30, 2018

8 of 11 checks passed

jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

rallytime added a commit that referenced this pull request Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.