Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pchanges with changes to make onchanges/prereq work in test mode #49832

Merged
merged 8 commits into from Oct 2, 2018

Conversation

@terminalmage
Copy link
Contributor

commented Sep 29, 2018

Fixes #49753
Fixes #45895

@salt-jenkins salt-jenkins requested review from saltstack/team-boto Sep 29, 2018
@terminalmage terminalmage changed the title Replace pchanges with changes make onchanges/prereq work in test mode Replace pchanges with changes to make onchanges/prereq work in test mode Sep 29, 2018
@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2018

@terminalmage There are some lint errors that need some attention, please. Thanks!

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2018

@cachedout Done.

@terminalmage terminalmage force-pushed the terminalmage:issue45895 branch from db75a36 to 6006588 Oct 1, 2018
Since "pchanges" was never supported in the state compiler, and
"changes" is what these reqs always used, replacing "pchanges" with
"changes" will allow those requisites to work in test mode.
This allows for a state return dict to be repacked so that the top level
keys are the IDs, making it much easier to analyze and craft asserts
against the results.
this requisite passes a __prerequired__ kwarg so these need to support
**kwargs for that reason.

This also changes the comment for salt.function in test mode because
it's inaccurate and doesn't make sense.
@terminalmage terminalmage force-pushed the terminalmage:issue45895 branch from 6006588 to 92d589e Oct 1, 2018
@isbm
isbm approved these changes Oct 1, 2018
@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2018

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2018

Test should pass now, just needed to be updated to reflect pchanges removal

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2018

There should probably be a notice about this in the Neon release notes.

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2018

I'll add this on Tuesday.

@terminalmage

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2018

@rallytime Since I just opened a PR to make a documentation addition in the same section that documentation of onchanges/prereq would have needed to go, rather than making conflicting changes that would require a rebase I decided to add them to the other PR (#49864).

terminalmage added a commit to terminalmage/salt that referenced this pull request Oct 2, 2018
@rallytime rallytime merged commit 014078d into saltstack:develop Oct 2, 2018
7 of 11 checks passed
7 of 11 checks passed
codeclimate 48 issues to fix
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
@max-arnold max-arnold referenced this pull request Oct 30, 2018
7 of 7 tasks complete
@Oloremo

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Really I'd like this to be ported to Fluorine. Test mode makes close to 0 sense without seeing diffs.

@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

@saltstack/team-core based on comments from the community, it might be a good idea to backport this #45895 (comment)

@angeloudy

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

Which release will this PR be merged into?
I cannot believe that 2019.2.0 is released with such a huge bug not fixed.

@KChandrashekhar

This comment has been minimized.

Copy link

commented Mar 28, 2019

After discussion with Tom, it's been determined this needs to be back ported

@Ch3LL Ch3LL referenced this pull request Apr 4, 2019
garethgreenaway added a commit that referenced this pull request Apr 12, 2019
Backport #49832 into 2018.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.