Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually catch the exception when we fail #49870

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
2 participants
@KaiSforza
Copy link
Contributor

commented Oct 2, 2018

This should actually cause builds to fail when any part in the try block
fails. We still delete instances and try junit rendering, but if things
fail then they get marked on github as failed.

@dubb-b @rallytime @gtmanfred

Actually catch the exception when we fail
This should actually cause builds to fail when any part in the try block
fails. We still delete instances and try junit rendering, but if things
fail then they get marked on github as failed.
@KaiSforza

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2018

We're going to need to merge this forward soon for the PR builds to fail correctly.

@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2018

Can you just open prs for the other two branches?

@gtmanfred gtmanfred merged commit 0662e37 into saltstack:2017.7 Oct 3, 2018

7 of 10 checks passed

jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
@KaiSforza

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2018

Should be two other with you mentioned #49876 #49877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.