Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with windows file permissions when using reset=True #49872

Merged
merged 5 commits into from Oct 5, 2018

Conversation

Projects
None yet
3 participants
@twangboy
Copy link
Contributor

commented Oct 3, 2018

What does this PR do?

Fix issues with file permissions:

  • Fix stacktrace when attempting to iterate over None
  • Check permissions using the resolved username
  • Set permissions using the resolved username
  • Reload file permissions prior to resetting
  • Compare usernames using lower()

What issues does this PR fix or reference?

#49861

Tests written?

Yes

Commits signed with GPG?

Yes

twangboy added some commits Oct 2, 2018

Fix issues with file permissions
Fix stacktrace when attempting to iterate over None
Check permissions using the resolved username
Set permissions using the resolved username
Reload file permissions prior to resetting
Compare usernames using lower()
Add tests for check_perms
Fix some docs

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Oct 3, 2018

@twangboy twangboy added the 2018.3.4 label Oct 3, 2018

@dwoz

dwoz approved these changes Oct 3, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2018

twangboy added some commits Oct 3, 2018

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2018

@twangboy The linux tests are failing here: https://jenkinsci.saltstack.com/job/pr-kitchen-centos7-py2/job/PR-49872/2/

And can you double check the list of failures for the windows tests? I am not certain if those failures are related to this change or not.

@rallytime
Copy link
Contributor

left a comment

👍 for new tests!

@rallytime rallytime merged commit c0e2404 into saltstack:2018.3 Oct 5, 2018

5 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@twangboy twangboy deleted the twangboy:fix_49861 branch Oct 5, 2018

twangboy added a commit to twangboy/salt that referenced this pull request Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.