Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually catch the exception when we fail #49876

Merged
merged 1 commit into from Oct 3, 2018

Conversation

Projects
None yet
2 participants
@KaiSforza
Copy link
Contributor

commented Oct 3, 2018

This should actually cause builds to fail when any part in the try block
fails. We still delete instances and try junit rendering, but if things
fail then they get marked on github as failed.

@gtmanfred

Actually catch the exception when we fail
This should actually cause builds to fail when any part in the try block
fails. We still delete instances and try junit rendering, but if things
fail then they get marked on github as failed.

@gtmanfred gtmanfred merged commit 42b540b into saltstack:2018.3 Oct 3, 2018

1 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit is being built
Details
jenkins/pr/docs Testing docs...
Details
jenkins/pr/lint Testing lint...
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.