Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lgpo better comments on user right assignments #49902

Merged
merged 2 commits into from Oct 5, 2018

Conversation

Projects
None yet
3 participants
@lomeroe
Copy link
Contributor

commented Oct 4, 2018

What does this PR do?

Ensure that a comment is set if a user right assignment is already properly configured and add a note that the user/group(s) already has the right if cumulative_rights_assignments is True

What issues does this PR fix or reference?

#48661
#49582

Previous Behavior

A comment was not always provided that the policy was already configured. Also adds an additional comment when cumulative_rights_assignemtns is True noting that the user/group in question already has the right.

New Behavior

Comments state that the user rights assignment is already configured.

Tests written?

No

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

add comments on user right assignment policies when they are already set
and note if cumulative_rights_assignment is True that the particular
user is already granted the right

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Oct 4, 2018

@rallytime rallytime merged commit d3a909f into saltstack:2018.3 Oct 5, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.