Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fixes to MySQL module #49918

Conversation

Projects
None yet
2 participants
@garethgreenaway
Copy link
Member

commented Oct 6, 2018

What does this PR do?

Updating the mysql update to handle changes in version 8.0.11 where PASSWORD was removed. Updating unit tests.

What issues does this PR fix or reference?

#48204

Previous Behavior

Release 8.0.11 removed the PASSWORD function to generate passwords from string. Previous this was used when creating a user as well as comparing existing passwords to those provided via CLI or in a state file.

New Behavior

Check version, if 8.0.11 or greater we use avoid using PASSWORD and when comparing passwords use a new function verify_login to test if the username & password work.

Tests written?

Yes. Existing tests updated.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

garethgreenaway added some commits Oct 6, 2018

Updating the mysql update to handle changes in version 8.0.11 where P…
…ASSWORD was removed. Updating unit tests.
Mike Place

@rallytime rallytime merged commit 18fb5df into saltstack:2018.3 Oct 10, 2018

8 of 10 checks passed

jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.