Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing `pkg_resources` package #49938

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@s0undt3ch
Copy link
Member

commented Oct 8, 2018

What does this PR do?

See title

Previous Behavior

Salt loader logged a traceback

2018-10-08 17:44:05,790 [salt.loader      :1469][DEBUG   ][7386] Failed to import states pip_state:
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/salt/loader.py", line 1459, in _load_module
    mod = imp.load_module(mod_namespace, fn_, fpath, desc)
  File "/usr/lib/python2.7/site-packages/salt/states/pip_state.py", line 26, in <module>
    import pkg_resources
ImportError: No module named pkg_resources
2018-10-08 17:44:05,792 [salt.utils.lazy  :100 ][DEBUG   ][7386] LazyLoaded portage_config.get_missing_flags

New Behavior

No logged traceback and module still does not load if package is missing.

Tests written?

No

Commits signed with GPG?

Yes

@rallytime rallytime merged commit 614d172 into saltstack:2018.3 Oct 9, 2018

6 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.