Fix nova module cooperation with python-novaclient#49977
Merged
rallytime merged 4 commits intosaltstack:developfrom Oct 11, 2018
Merged
Fix nova module cooperation with python-novaclient#49977rallytime merged 4 commits intosaltstack:developfrom
rallytime merged 4 commits intosaltstack:developfrom
Conversation
ghost
self-requested a review
gtmanfred
approved these changes
Oct 10, 2018
Contributor
gtmanfred
left a comment
gtmanfred
left a comment
There was a problem hiding this comment.
This looks great, thanks for the help here.
We have also moved everything over to the newer openstack shade module starting in 2018.3. but this would be good to backport to 2017.7
gtmanfred
added
the
bugfix-bckport
Contributor
|
@slivik The pylint check found some errors. Can you fix those? |
cachedout
reviewed
Oct 11, 2018
Contributor
|
@slivik This won't back-port cleanly to the 2017.7 branch. Would you be willing to make this change there as well? |
rallytime
removed
the
bugfix-bckport
Contributor
Author
|
@rallytime I have created new PR adding openstack nova module and fixing possibility to back-port it cleanly to the 2017.7 branch. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
novamodule andsalt.utils.openstack.novamodule:Previous Behavior
It was not possible to use
novamodule whenpython-novaclient > 6.0.1installed.New Behavior
Now
novamodule works with newer version ofpython-novaclient.Tests written?
Yes
Commits signed with GPG?
Yes