Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license date and include NOTICE #49979

Merged
merged 2 commits into from Oct 11, 2018

Conversation

Projects
None yet
4 participants
@cachedout
Copy link
Collaborator

commented Oct 10, 2018

Compliance with default rules outlined here: https://github.com/todogroup/repolinter

Mike Place

@cachedout cachedout requested a review from thatch45 Oct 10, 2018

Mike Place

@rallytime rallytime merged commit c7d2482 into saltstack:2018.3 Oct 11, 2018

6 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
@holmboe

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

I really think the NOTICE file contains the wrong copyright. Is it intentional that Saltstack assigns the copyright of its work to the Apache Software Foundation? I cannot find on apache.org that Salt is a software project under the ASF. Never mind that you use Apache License 2.0. You should read what the license says about NOTICE file and amend it accordingly.

Ping @thatch45 @rallytime @cachedout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.