Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AddPrinterDrivers #49980

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
2 participants
@twangboy
Copy link
Contributor

commented Oct 10, 2018

What does this PR do?

Adds support for the "Devices: Prevent users from installing printer drivers" Group Policy Object.

What issues does this PR fix or reference?

#49971

Previous Behavior

[ERROR   ]  Unable to find Machine policy Devices: Prevent users from installing printer drivers
local:
----------
          ID: prevent_users_installing_printer_drivers
    Function: lgpo.set
      Result: False
     Comment: Unable to find Machine policy Devices: Prevent users from installing printer drivers
     Started: 20:01:55.460000
    Duration: 672.0 ms
     Changes:

New Behavior

Successfully sets the Group Policy

Tests written?

No

Commits signed with GPG?

Yes

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Oct 10, 2018

@twangboy twangboy added the 2018.3.4 label Oct 10, 2018

@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Oct 16, 2018

Why is this going into a point release?

@twangboy

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

It's not changing behavior... It just adding another policy that can be set. SecDev needs it.

@cachedout cachedout merged commit 0069247 into saltstack:2018.3 Oct 19, 2018

6 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@twangboy twangboy deleted the twangboy:lgpo_add_printer_drivers branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.