Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/saltstack/salt/issues/49883 #50004

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
4 participants
@kiemlicz
Copy link
Contributor

commented Oct 11, 2018

Using named argument in PublicIPAddress azure network_models API call

What does this PR do?

Fixes azure network api usage when creating public IP

What issues does this PR fix or reference?

#49883

Previous Behavior

[ERROR   ] There was a profile error: __init__() takes exactly 1 argument (2 given)
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/salt/cloud/cli.py", line 281, in run
    self.config.get('names')
  File "/usr/lib/python2.7/dist-packages/salt/cloud/__init__.py", line 1454, in run_profile
    ret[name] = self.create(vm_)
  File "/usr/lib/python2.7/dist-packages/salt/cloud/__init__.py", line 1284, in create
    output = self.clouds[func](vm_)
  File "/var/cache/salt/master/extmods/clouds/azurearm.py", line 1418, in create
    vm_request = request_instance(vm_=vm_)
  File "/var/cache/salt/master/extmods/clouds/azurearm.py", line 1013, in request_instance
    kwargs=vm_
  File "/var/cache/salt/master/extmods/clouds/azurearm.py", line 859, in create_network_interface
    six.text_type(pub_ip_data.id),  # pylint: disable=no-member
TypeError: __init__() takes exactly 1 argument (2 given)
#49883
Using named argument in PublicIPAddress azure network_models API call

@salt-jenkins salt-jenkins requested a review from saltstack/team-cloud Oct 11, 2018

@gtmanfred

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2018

@nicholasmhughes can you make sure this isn't just a terrible idea?

Thanks,
Daniel

@nicholasmhughes

This comment has been minimized.

Copy link
Contributor

commented Oct 12, 2018

@gtmanfred explicit parameters are never terrible ideas. 😉
Looks good.

@gtmanfred gtmanfred merged commit d920b9d into saltstack:develop Oct 12, 2018

8 of 11 checks passed

jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

rallytime added a commit that referenced this pull request Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.