Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed kwargs to db_exists in db_remove method #50013

Merged
merged 3 commits into from Oct 18, 2018

Conversation

Projects
None yet
2 participants
@Giandom
Copy link
Contributor

commented Oct 12, 2018

What does this PR do?

Add kwargs to the db_exists function call

What issues does this PR fix or reference?

The function db_remove fails because the call to the dbexists function needs kwargs to connect to the db if you're passing all connection parameters from cli.

Previous Behavior

db_remove function fails passing connection parameters from cli

New Behavior

db_remove works

Tests written?

No

Commits signed with GPG?

No

Giandom and others added some commits Oct 12, 2018

Passed kwargs to db_remove
The function db_remove fails because the call to the dbexists function needs kwargs to connect to the db if you're passing all connection parameters from cli.
Mike Place

@cachedout cachedout merged commit 5123488 into saltstack:2018.3 Oct 18, 2018

7 of 10 checks passed

jenkins/pr/py2-centos-7 The py2-centos-7 job has failed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
@cachedout

This comment has been minimized.

Copy link
Collaborator

commented Oct 18, 2018

Thank you, @Giandom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.