Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2018.3] Fix some pylint issues that have popped up recently #50060

Merged
merged 2 commits into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@rallytime
Copy link
Contributor

commented Oct 15, 2018

13:19:51 [salt linting] ************* Module salt.engines.slack
13:19:51 [salt linting] salt/engines/slack.py:634: [E8301(expected-1-blank-line-found-0), ] PEP8 E301: expected 1 blank line, found 0
13:19:51 [salt linting] ************* Module salt.modules.consul
13:19:51 [salt linting] salt/modules/consul.py:217: [E8711(comparison-to-None-should-be-if-cond-is-None), ] PEP8 E711: comparison to None should be 'if cond is None:'
13:19:51 [salt linting] ************* Module salt.modules.lxc
13:19:51 [salt linting] salt/modules/lxc.py:4692: [E8711(comparison-to-None-should-be-if-cond-is-None), ] PEP8 E711: comparison to None should be 'if cond is None:'
13:19:51 [salt linting] ************* Module salt.modules.win_lgpo
13:19:51 [salt linting] salt/modules/win_lgpo.py:4340: [E1400(null-byte-unicode-literal), ] Null byte used in unicode string literal (should be wrapped in str())

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Oct 15, 2018

@rallytime rallytime merged commit f1bcb1f into saltstack:2018.3 Oct 15, 2018

3 of 10 checks passed

jenkins/pr/docs Testing docs...
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
jenkins/pr/py2-ubuntu-1604 running py2-ubuntu-1604...
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-centos-7 running py3-centos-7...
Details
jenkins/pr/py3-ubuntu-1604 running py3-ubuntu-1604...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/lint The lint job has passed
Details

@rallytime rallytime deleted the rallytime:fix-lint branch Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.