Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg.install bugfix #50061

Merged
merged 2 commits into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@rongzeng54
Copy link
Contributor

commented Oct 15, 2018

What does this PR do?

For example
the RPM package which current installed is 8:3.8.12-6.n.el7,
the RPM package which hope to install is 9:3.8.12-4.n.el7,
The yumpkg.py will run "yum downgrade" but not "yum install".

What issues does this PR fix or reference?

No

Previous Behavior

Compare the package version without epoch.

New Behavior

Compare the package version with epoch.

Tests written?

No

Commits signed with GPG?

No

zr

@salt-jenkins salt-jenkins requested a review from saltstack/team-suse Oct 15, 2018

@gtmanfred gtmanfred requested a review from terminalmage Oct 15, 2018

@terminalmage
Copy link
Contributor

left a comment

Good catch, @rongzeng54. I've added a unit test for this to the PR.

@rallytime We should backport this fix.

@rallytime
Copy link
Contributor

left a comment

👍

Nice team work @rongzeng54 and @terminalmage!

@rallytime rallytime merged commit 006cbf6 into saltstack:develop Oct 16, 2018

10 of 11 checks passed

codeclimate 3 issues to fix
Details
WIP ready for review
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

@rongzeng54 rongzeng54 deleted the rongzeng54:zr.pkg.install.bugfix branch Oct 17, 2018

cachedout pushed a commit that referenced this pull request Oct 19, 2018

Mike Place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.