Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all string kwargs passed to Tornado's httpclient are str types #50080

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@terminalmage
Copy link
Contributor

commented Oct 16, 2018

Failing to do so will result in a TypeError when running setopt in pycurl, as it does not support unicode types on Python 2.

Fixes #49275.

Ensure all string kwargs passed to Tornado's httpclient are str types
Failing to do so will result in a `TypeError` when running setopt in
pycurl, as it does not support `unicode` types on Python 2.

@rallytime rallytime merged commit 7092879 into saltstack:2018.3 Oct 16, 2018

6 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
jenkins/pr/py2-centos-7 running py2-centos-7...
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@terminalmage terminalmage deleted the terminalmage:issue49275 branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.