Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `test_win_pkg` yet again #50085

Merged
merged 7 commits into from Oct 19, 2018

Conversation

Projects
None yet
3 participants
@dwoz
Copy link
Contributor

commented Oct 16, 2018

What does this PR do?

We just fixed a bug in check_file_list_cache which should have resolved the test_win_pkg failure but this test still fails intermittently. This PR adds flushes and syncs the new file to make sure it's available. In addition to adding a debug log when file_list is returned from a cache.

Tests written?

No

Commits signed with GPG?

Yes

dwoz added some commits Oct 16, 2018

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Oct 16, 2018

@dwoz dwoz requested review from Ch3LL and removed request for saltstack/team-windows Oct 16, 2018

@damon-atkins

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

Should not need to flush. Flush just ensures its on physical disk. With out the flush, the file is read back from memory cache this memory cache is shared by everything, so all reads from any process will get the same results.. If their is a difference this would indicate a very large OS bug. If you have python closed the file, the data should not be sitting in any python buffer.

dwoz added some commits Oct 17, 2018

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2018

@damon-atkins Thanks, I was just grasping at straws with fsync thing. The log in the first PR test run confirms that there is still a file_list_cache problem.

@dwoz

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2018

The log from the last failing test run showed this...

Returning file list from cache: age=-3092 cache_time=0 c:\users\admini~1\appdata\local\temp\salt-tests-tmpdir\rootdir\cache\file_lists\roots\base.p

For some reason the cache file's modified time was 3092 seconds in the future. I patched to detect this case an log that it happened.

Mike Place
@damon-atkins

This comment has been minimized.

Copy link
Member

commented Oct 18, 2018

I see your looking at time. Are you running NTP? Virtual Machine are good at loosing or gaining time. I assume everything is processed as UTC time. I raise a PR to suggest some enhancements to the fileserver some time ago. #45314

@dwoz dwoz merged commit 0ece06e into saltstack:2018.3 Oct 19, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit is being built
Details
jenkins/pr/py2-windows-2016 running py2-windows-2016...
Details
jenkins/pr/py3-windows-2016 running py3-windows-2016...
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.