Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #50142, stringutils.to_none #50143

Merged
merged 2 commits into from Oct 22, 2018

Conversation

Projects
None yet
3 participants
@m03
Copy link
Contributor

commented Oct 20, 2018

What does this PR do?

Fixes an AttributeError in stringutils.to_none by correcting the typo tex_type, which was introduced in PR #45429.

What issues does this PR fix or reference?

#50142

Previous Behavior

The to_none function was broken.

New Behavior

The to_none function is no longer broken.

Tests written?

Yes

Commits signed with GPG?

Yes

m03 added some commits Oct 20, 2018

@gtmanfred gtmanfred merged commit 19a4386 into saltstack:develop Oct 22, 2018

11 checks passed

WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has passed
Details

cachedout pushed a commit that referenced this pull request Oct 23, 2018

Mike Place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.