Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a missing result for task.info #50161

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@rmarcinik
Copy link
Contributor

commented Oct 22, 2018

There is a possible value for Last Run Result in the windows task scheduler that is missing from the results dictionary. It raises a confusing KeyError from task.info if the task ends up in this state.

Add a missing result for task.info
There is a possible value for Last Run Result in the windows task scheduler that is missing from the results dictionary.  It raises a confusing KeyError from task.info if the task ends up in this state.

@salt-jenkins salt-jenkins requested a review from saltstack/team-windows Oct 22, 2018

@dwoz

dwoz approved these changes Oct 22, 2018

@rallytime rallytime merged commit 16eece3 into saltstack:2018.3 Oct 23, 2018

7 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has passed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has passed
Details

@rmarcinik rmarcinik deleted the rmarcinik:patch-1 branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.